-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for user-defined rules #177
Conversation
What is the development status of this now? |
What is actually the current state of this? Is this coming any time soon? And, is there already a way how to define rules in some other way, I've seen it mentioned a few times. |
Pending a design decision on #172 |
API is still in need of work and right now only adds custom rules for forward mode. But nevertheless it does work, and has (and hopefully passes) tests, so I want to merge. |
The 1.6 issue seems like an inling issue? |
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
==========================================
- Coverage 76.33% 74.33% -2.00%
==========================================
Files 17 18 +1
Lines 4226 4419 +193
==========================================
+ Hits 3226 3285 +59
- Misses 1000 1134 +134
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Vetoing merging this for now, we should first release a version with the accumulated fixes before landing this PR. |
@vchuravy with the landed jll bump, have time to review this (and possibly ponder 1.6 no inling) |
I have a strong preference to focus on stabilizing Enzyme.jl for a new release, a stretchgoal for that is GC integration and visit this for the next minor bump of Enzyme.jl |
b8d735e
to
0573240
Compare
Haven't thought through reverse mode yet, but I think:
Is a decent start for the forward API. |
Co-authored-by: William Moses <gh@wsmoses.com> Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Rebased in #589 |
TODO: